Why your team doesn't need to use pull requests

infrastructure-as-code.com (Kief Morris) ยท article ยท 2021-01-02 source โ†— Reader ๐Ÿ–ฅ๏ธ

Feedback LoopsPair & Mob ProgrammingPull Requests & Async Code ReviewTrunk-Based & Continuous Delivery
Pull requests were designed to vet contributions from untrusted outside contributors, so applying them to a trusted team's own code sacrifices Continuous Integration's fast feedback and flow for no corresponding risk-reduction benefit; teams should instead integrate continuously and get code review through pairing, periodic group reviews, or post-integration pipeline approval gates.

practical ยท argumentative โ€” Argues for a specific team practice (adopt CI over PR gating for trusted team members) using a historical/origin argument plus a flow/feedback-delay comparison.

Structure

PartRole
Origin story: GitHub built pull requests to let maintainers safely accept patches from untrusted outside contributors.context
Claim that many teams now apply PRs to their own trusted members by default, including the 'airport security for family' analogy.thesis statement
Definition and mechanics of Continuous Integration (merge + test at least daily, fast automated feedback).evidence/context
Side-by-side delay comparison: PR turnaround (~30 min best case, often much worse) vs. CI feedback (minutes) vs. the daily-integration requirement most PR workflows violate.evidence
Three alternative review mechanisms that preserve human review without delaying integration: pair programming, periodic (e.g. weekly) group reviews, and post-integration pipeline approval gates.solution / rebuttal to 'but we need review'
Conclusion: review timing can move (synchronous during authoring, or after integration/test) without needing to be a pre-integration gate; a faster loop encourages smaller, more frequent, higher-quality commits.conclusion

Key terms

Propositions

Arguments

A team whose members share norms and trust should default to Continuous Integration rather than pull requests for integrating code. strength: high
Explicit premises:
Implicit premises:
Inferences:

Narratives

Questions addressed

Gaps

Closes gaps elsewhere

Related documents